Keith Packard keithp at keithp.com
Fri Jul 11 02:29:29 PDT 2014

Hans de Goede <hdegoede at redhat.com> writes:

> Looks like the value of ODEV_ATTRIB_DRIVER was not updated when the patch
> adding it got rebased on top of a newer server version.

This points out some weaknesses in the config_odev API; it shouldn't be
possible to crash the server in this way. Here's a patch which tries to
make this API robust against future errors and emit error messages that
should help track down incorrect usage.

I am going to insist that the API be made robust (either with this patch
or something which has the desired effect; I haven't done more than
compile this one) while the existing bug is still present so that we can
verify that the code now survives this abuse without crashing. After
that works, I can merge in both that and the actual fix.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-config-Make-OdevAttribute-API-robust-against-mis-usi.patch
Type: text/x-diff
Size: 4615 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140711/e82a53c0/attachment.patch>
-------------- next part --------------

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140711/e82a53c0/attachment.sig>

More information about the xorg-devel mailing list