[PATCH] Revert "glamor: Fix coordinates handling for composite source/mask pictures"

Keith Packard keithp at keithp.com
Wed Jul 16 16:13:40 PDT 2014

Michel Dänzer <michel at daenzer.net> writes:

> After several complaints about this revert from users of other DEs
> (because it broke their systray icons again), I tried to reproduce the
> kwin problem shown on
> http://markus.members.selfnet.de/xorg/glamor_kwin.png without the revert
> again, but couldn't. Markus, can you still reproduce this problem
> without the revert? If yes, please provide detailed instructions to
> reproduce. If not, it was probably fixed by something else in the meantime.

I think I understand the code and now believe that both the original
fixed versions are incorrect. However, I cannot reproduce any of the
problems we've had reported. I've placed an explanation of the bug and
the fix in the patch attached here. In theory, this should fix *both*
the original kwin problem and the systray icons. I would love to see
this tested soon if possible. I wouldn't mind slipping this into 1.16;
it seems "low risk" to me, and solves a fairly serious regression with

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-glamor-Fix-temp-picture-coordinates-in-glamor_compos.patch
Type: text/x-diff
Size: 8252 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140716/ca5dec4d/attachment.patch>
-------------- next part --------------

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140716/ca5dec4d/attachment.sig>

More information about the xorg-devel mailing list