[PATCH 06/22] miext/shadow: Remove shadowInit

Keith Packard keithp at keithp.com
Mon Jul 28 12:35:44 PDT 2014

Adam Jackson <ajax at redhat.com> writes:

> This code is nonsensical.  You end up creating a screen-sized pixmap
> that's totally detached from everything else, which you then listen for
> damage on, which means you'll never hear any damage, which means your
> shadow update hooks will never get called.  Any driver using this would
> be sorely disappointed.

I have this vague memory that a caller of this would actually pull the
pixmap out of the shadow code and use that as the screen pixmap. I'm not
sure that's correct, but I can't see how else this could be useful

In any case, that would be crazy.

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140728/216f8df1/attachment.sig>

More information about the xorg-devel mailing list