[PATCH] Make sure X_BYTE_ORDER is defined for servermd.h

Michel Dänzer michel at daenzer.net
Thu Jul 31 18:30:18 PDT 2014


On 01.08.2014 00:39, Keith Packard wrote:
> Michel Dänzer <michel at daenzer.net> writes:
> 
>> This works, but how about this on top:
>>
>> diff --git a/include/servermd.h b/include/servermd.h
>> index b3fe6df..c88a542 100644
>> --- a/include/servermd.h
>> +++ b/include/servermd.h
>> @@ -47,10 +47,9 @@ SOFTWARE.
>>  #ifndef SERVERMD_H
>>  #define SERVERMD_H 1
>>
>> -#ifdef HAVE_DIX_CONFIG_H
>> -#include "dix-config.h"
>> -#else
>> -#include "xorg-server.h"
>> +#if !defined(_DIX_CONFIG_H_) && !defined(_XORG_SERVER_H_)
>> +#error Drivers must include xorg-server.h before any other xserver headers
>> +#error xserver code must include dix-config.h before any other headers
>>  #endif
>>
>>  #if X_BYTE_ORDER == X_LITTLE_ENDIAN
>>
>>
>> The same check could be added to other server headers.
> 
> Merged.
>    61afe95..e31564e  master -> master

Thanks, but X_BYTE_ORDER still needs to be added to xorg-server.h,
doesn't it? By 'this on top', I meant literally folding it into your patch.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 234 bytes
Desc: OpenPGP digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140801/35233919/attachment.sig>


More information about the xorg-devel mailing list