[PATCH] present: Queue flips for later execution. Begging for review.

Keith Packard keithp at keithp.com
Mon Jun 2 20:56:32 PDT 2014

Chris Wilson <chris at chris-wilson.co.uk> writes:

> The patch relaxes the restriction that there be a single pending flip,
> and allows the client to queue up a series of fullscreen swaps. However,
> we don't recheck pixmaps for being viable for flipping after the vblank
> event as we rely on the ClipNotify hook aborting any flip after a Window
> change. I think this check now needs to scan all pending flips.

The driver gets a 'last appeal' in the present_flip call, and if that
says 'no', then the extension falls back to a copy.

> Other than that, the patch does what it says on the tin, though you
> could mention the impact this has caused by the regular flip-unflip.

Not sure what you mean here; are you saying that I should mention that
the code fixes a bug in the existing stuff where doing sync flips will
regularly cause a switch between flipping and copying?

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140602/4ab56e82/attachment.sig>

More information about the xorg-devel mailing list