[PATCH] present: Queue flips for later execution. Begging for review.

Chris Wilson chris at chris-wilson.co.uk
Tue Jun 3 00:39:45 PDT 2014

On Tue, Jun 03, 2014 at 12:27:45AM -0700, Keith Packard wrote:
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> > The driver doesn't check that the Window is still suitable for flipping,
> > it only checks if the buffer is suitable for scanning out. I think you
> > need to run present_check_flip_window() on all queued flips.
> present_check_flip_window is called when the window clip list changes.


Eeek, overlooked the loop at the end of present_check_flip_window that
did precisely what I was looking for.

> > Just a mention of how the bug is observed in practice. It wasn't until
> > you pointed out the effects of this patch on irc that I realised it
> > fixed the same flip-unflip issue I saw during testing.
> Sounds good. I'll update the commit message.

After thoroughly confusing myself,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Chris Wilson, Intel Open Source Technology Centre

More information about the xorg-devel mailing list