[PATCH 3/4] dix: fix pixmap leak on server reset

Keith Packard keithp at keithp.com
Wed Jun 4 21:29:16 PDT 2014

Brendan King <Brendan.King at imgtec.com> writes:

> Without the patch in place,  screen->DeviceCursorCleanup was never
> being called, as dev->spriteInfo->sprite was NULL for every
> device. DisableDevice is called before CloseDevice, and DisableDevice
> will call FreeSprite if the device is enabled, which will set
> dev->spriteInfo->sprite to NULL.

Thanks for your explanation; this all makes sense now. DisableDevice was
changed to free the sprite back on 2012-06-06 in commit

Looks like we've been leaking the cursor stuff for a while now. And, it
looks like the FreeSprite call is entirely unnecessary in CloseDevice as
DisableDevice is always called first from RemoveDevice.

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140604/f06219d0/attachment-0001.sig>

More information about the xorg-devel mailing list