[PATCH] libx11 xkb/XKBMAlloc.c fix check for map->num_types

Alan Coopersmith alan.coopersmith at oracle.com
Thu Jun 5 23:21:16 PDT 2014

On 06/ 5/14 04:21 PM, Daniel Stone wrote:
> Hi,
> On 5 June 2014 15:46, walter harms <wharms at bfs.de <mailto:wharms at bfs.de>> wrote:
>     fix: check for map->num_types overflow
>     compiletestested, i have no example to check this condition
>     but i guess that this was the original author intended
>   This isn't an overflow check, but one to ensure that we always have at least
> XkbNumRequiredTypes types in the map.

Right - it looks like we just want to remove the ! from
(!map->num_types < XkbNumRequiredTypes) instead of inverting the check.

	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc

More information about the xorg-devel mailing list