xserver dependency on crypto library because of a hashmap

Marek Behun kabel at blackhole.sk
Sun Jun 8 06:46:19 PDT 2014

The functions in xserver/render/glyph.c (and also in render.c) use
external crypto library sha1 algorithm for a HashMap (of glyphs). This
is the only occurance of x_sha1_* usage in xserver.

The x_sha1_* functions depend on external library (of packager
choosing: openssl/libgcrypt/libnettle/other). 300 lines of code only to
wrap external library calls. In those 300 lines one could write some
simpler, faster hashmap hash function (isn't crc32 or something simpler
good enough for this?), or one could copy the entire code for sha1 from
another library.

Depending on external crypto library because of a hashmap is insane for
Christ's sake.

I have also created a bug report for this:

Marek Behun
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140608/693d65a3/attachment.sig>

More information about the xorg-devel mailing list