[PATCH] present: Remove executing vblank from window list. Bug# 79709.

Axel Davy axel.davy at ens.fr
Sat Jun 21 15:52:19 PDT 2014


On 17/06/2014 18:53, Keith Packard wrote :
> Once the vblank is actually getting executed, it's lifetime is no
> longer tied to the window, and so it shouldn't be controlled by window
> destruction. In particular, if the vblank is queued for flip, it will
> get stored in the flip_pending field, and will be correctly destroyed
> when the flip completes.
>
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>   present/present.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/present/present.c b/present/present.c
> index 1bf3a58..165860a 100644
> --- a/present/present.c
> +++ b/present/present.c
> @@ -578,6 +578,7 @@ present_execute(present_vblank_ptr vblank, uint64_t ust, uint64_t crtc_msc)
>       }
>   
>       xorg_list_del(&vblank->event_queue);
> +    xorg_list_del(&vblank->window_list);
>       vblank->queued = FALSE;
>   
>       if (vblank->pixmap && vblank->window) {
Nice fix,

Reviewed-by: Axel Davy <axel.davy at ens.fr>


More information about the xorg-devel mailing list