[PATCH 05/27] glamor: Do glyph private init at screeninit time, and other stuff at CSR.

Eric Anholt eric at anholt.net
Wed Mar 12 17:37:35 PDT 2014


Markus Wick <markus at selfnet.de> writes:

> Am 2014-03-11 22:30, schrieb Eric Anholt:
>> diff --git a/glamor/glamor.h b/glamor/glamor.h
>> index e25dc73..9cda46d 100644
>> --- a/glamor/glamor.h
>> +++ b/glamor/glamor.h
>> @@ -131,14 +131,6 @@ extern _X_EXPORT void
>> glamor_set_screen_pixmap(PixmapPtr screen_pixmap,
>> 
>>  extern _X_EXPORT uint32_t glamor_get_pixmap_texture(PixmapPtr pixmap);
>> 
>> -/* @glamor_glyphs_init: Initialize glyphs internal data structures.
>> - *
>> - * @pScreen: Current screen pointer.
>> - *
>> - * This function must be called after the glamor_init and the texture
>> - * can be allocated. An example is to call it when create the screen
>> - * resources at DDX layer.
>> - */
>>  extern _X_EXPORT Bool glamor_glyphs_init(ScreenPtr pScreen);
>
> This function isn't (and shouldn't be?) used outside of glamor, so this 
> should be moved to glamor_priv.h.

I noted that in the commit message -- we retain this as a public symbol
so drivers keep working without needing changes due to this series
landing.

Some day later, if we care, we can drop the compatibility, but for now
I'd rather make their transition to using server glamor easy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140312/c7d7edda/attachment.pgp>


More information about the xorg-devel mailing list