[PATCH v2 0/5] xwayland: Refactor bits of XKB functionality

Kristian Høgsberg krh at bitplanet.net
Thu Mar 13 11:41:13 PDT 2014


On Wed, Mar 12, 2014 at 7:56 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> Refactored series. I really disliked the XkbCompContext patches, something
> just didn't sit right with it. I wish we could use fmemopen() but short of
> that or a bigger refactoring this should do. Replaces the xkbcomp-specific
> context with a callback. After all, what we need is a stream to write to
> xkbcomp, the rest of the context was superfluous anyway. This patchset does
> that - sets everything up, then calls the callback.
>
> The rest is mostly identical, except that I split two features out (and
> replaced all the tabs with spaces...)

That's fine, I think I was trying to avoid a callback, but I don't
think there was a good reasons for that.  This new approach looks good
too, for the new patches,

Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>

> Cheers,
>   Peter
>
>
>


More information about the xorg-devel mailing list