[PATCH 10/10] glamor: Add glamor_program based poly_text and image_text

Keith Packard keithp at keithp.com
Sat Mar 22 14:27:36 PDT 2014


Markus Wick <markus at selfnet.de> writes:

> Am 2014-03-21 00:43, schrieb Keith Packard:
>>> more important to only get one mipmap level: max_level = 0
>> I copied this code from elsewhere; do you have a substitute suggestion?
>
> glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAX_LEVEL, 0);
> The other parameters are sampler parameters, max_level is a texture 
> parameter and affects allocation.

Do we need the other parameters then?

> So what will happen if a program only alloc and delete a font? As 
> font_get wasn't called, we delete a not initialized font.

Oh, good point, we'd end up deleting texture 0, which is either harmless
and unnecessary or a plain bad idea. I've added this to the code:

    if (!glamor_font->realized)
        return TRUE;

    /* Unrealize the font, freeing the allocated texture */
    glamor_font->realized = FALSE;

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140322/c6662a10/attachment.sig>


More information about the xorg-devel mailing list