[PATCH v2 RESEND 1/5] xfree86: Make driver matching consistent

Thierry Reding treding at nvidia.com
Fri Mar 28 04:03:45 PDT 2014


On Fri, Mar 14, 2014 at 04:54:08PM +0100, Aaron Plattner wrote:
> From: Thierry Reding <treding at nvidia.com>
> 
> Most of the driver enumeration functions take an array and a maximum
> number of entries that they are allowed to fill in. Upon success, they
> return the number of entries filled in. This allows them to be easily
> used to consecutively.
> 
> One exception is the xf86MatchDriverFromFiles() function, which doesn't
> return a value, so callers have to manually search the array for the
> first empty entry.
> 
> This commit modifies the xf86MatchDriverFromFiles() to behave the same
> way as others, which makes it easier to deal with.
> 
> Signed-off-by: Thierry Reding <treding at nvidia.com>
> Reviewed-By: Aaron Plattner <aplattner at nvidia.com>
> Tested-By: Aaron Plattner <aplattner at nvidia.com>
> Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
> ---
>  hw/xfree86/common/xf86AutoConfig.c  |  2 +-
>  hw/xfree86/common/xf86pciBus.c      | 24 ++++++++++--------------
>  hw/xfree86/common/xf86pciBus.h      |  5 +++--
>  hw/xfree86/common/xf86platformBus.c |  7 ++-----
>  4 files changed, 16 insertions(+), 22 deletions(-)

Keith,

Aaron indicated that you might have some comments or reservations about
this series? Did you have time to look at it?

Thierry

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140328/e9b589c0/attachment.sig>


More information about the xorg-devel mailing list