[PATCH] config by seat

[Laércio de Sousa]

Hi Oleg!

You'll need to take care with ServerLayout section. I've detected a small
problem with your patch in a very particular situation:

Consider a machine with two seats, seat0 and seat1. Suppose you only have a
file /etc/X11/xorg.conf.d/90-seat.conf with the following structure:

Section "Device"
    Identifier "device0"
    (...)
    MatchSeat "seat1"
EndSection

Section "Screen"
    Identifier "screen0"
    Device "device0"
    (...)
    MatchSeat "seat1"
EndSection

Section "ServerLayout"
    Identifier "layout0"
    Screen "screen0"
    (...)
    MatchSeat "seat1"
EndSection

In this situation, the seat0 X server will fail to find the default layout
and will crash. If you remove the ServerLayout section from file, this
problem disappears.

I would suggest also another improvement for your patch: could you modify
it so that you can get rid of those MatchSeat repetitions? For example, if
you have something like

Section "Device"
    Identifier "device0"
    (...)
    MatchSeat "seat1"
EndSection

Section "Screen"
    Identifier "screen0"
    Device "device0"
    (...)
EndSection

then seat0 X server should ignore screen "screen0", since it links to
device "device0", which already has a MatchSeat entry.

Regards,

CANTATE DOMINO CANTICUM NOVUM
QUIA MIRABILIA FECIT

Laércio


2014-03-28 8:39 GMT-03:00 Laércio de Sousa <lbsousajr at gmail.com>:

>
> 2014-03-27 17:05 GMT-03:00 Oleg Samarin <osamarin68 at gmail.com>:
>
>> Hello!
>>
>> Sometimes ago I made a patch that allows to configure Devices, Screens
>> and Layouts belonging to the different seats in a multi-seat
>> environment. It is useful for the setting up with several videocards
>> using propritery drivers (I've tested with Nvidia).
>>
>> Because my patch has not been sesolved upstream, I resend it again
>> adopted to the current master.
>>
>
> Acked-by: Laércio de Sousa <lbsousajr at gmail.com>
> Tested-by: Laércio de Sousa <lbsousajr at gmail.com>
>
> CANTATE DOMINO CANTICUM NOVUM
> QUIA MIRABILIA FECIT
>
> Laércio
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140328/01894478/attachment-0001.html>