[PATCH] dix/dispatch: DoGetImage: Use a single buffer

Mark Kettenis mark.kettenis at xs4all.nl
Sat Mar 29 16:19:26 PDT 2014


> From: Keith Packard <keithp at keithp.com>
> Date: Sat, 29 Mar 2014 12:40:07 -0700
>
> > In my case the problem shows up with Firefox, which apparently is
> > rendering images to the screen when downloading them, then grabs the
> > pixels with XGetImage() and re-renders using those grabbed pixels.
> > Seems utterly retarded to me, and it is potentially an issue with the
> > old cairo embedded by Firefox.
> 
> Sounds like we might actually want to fix this then.
> 
> You might  try the combination of your changes with Daniel's patch and
> see what you get; doing the whole GetImage in a single WriteToClient
> should help a bunch, especially when mixed with your change.

Hmm, I don't think Daniel's message ever made it to the list though.

I did send the libxtrans diff as a formal patch (now against git HEAD)
to the list though as I'm sure it is an essential part of the puzzle.


More information about the xorg-devel mailing list