[PATCH] glamor: Review changes for glamor_dash.c

Keith Packard keithp at keithp.com
Wed May 7 11:37:26 PDT 2014

Eric Anholt <eric at anholt.net> writes:

> 3 major changes:
> - Drops power-of-two alignment of our line vertex data, simplifying
>   the code.

I think Markus suggested that some hardware might like vertices aligned
on power-of-two boundaries? I find that improbable, given how large some
vertices are these days. I've merged this change in.

> - Stops reading from the VBO.  While on keithp's and my machines the
>   VBO is mapped cached, on many implementations it will be mapped WC,
>   making those reads extremely expensive.

Oh. Nice fix!

> - Style fixes (line wrapping, spaces around operators).

Thanks. Fixed.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140507/f916edc5/attachment.sig>

More information about the xorg-devel mailing list