[PATCH keyboard] Init LEDs to zero before querying the value

Peter Hutterer peter.hutterer at who-t.net
Wed May 7 20:01:03 PDT 2014


This way if the ioctl fails we don't set any unintended LEDs, but really this
patch is more to silence valgrind:

==7129== Conditional jump or move depends on uninitialised value(s)
==7129==    at 0x8DF99A1: GetKbdLeds (lnx_kbd.c:79)
==7129==    by 0x8DF8853: InitKBD (kbd.c:291)

Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
---
 src/lnx_kbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lnx_kbd.c b/src/lnx_kbd.c
index e69e1b6..811a7d7 100644
--- a/src/lnx_kbd.c
+++ b/src/lnx_kbd.c
@@ -70,7 +70,7 @@ SetKbdLeds(InputInfoPtr pInfo, int leds)
 static int
 GetKbdLeds(InputInfoPtr pInfo)
 {
-    char real_leds;
+    char real_leds = 0;
     int leds = 0;
 
     ioctl(pInfo->fd, KDGETLED, &real_leds);
-- 
1.9.0



More information about the xorg-devel mailing list