[PATCH v2] mi: start calculating the sprite trace from the first child of root

Keith Packard keithp at keithp.com
Thu May 8 10:27:11 PDT 2014

Peter Hutterer <peter.hutterer at who-t.net> writes:

> Introduced in
> 73698d41e41ce76bef2d9a90b46ac0c24ae148dd "Make XYToWindow a screen function"
> Moving the code into miwindow.c changed the start of the loop from
> RootWindow()->firstChild to DeepestSpriteWindow(). This function is only
> supposed to be called from miXYToWindow which resets spriteTraceGood to 1,
> thus DeepestSpriteWindow() is always the root window anyway.
> What got dropped was the firstChild as the first window to handle, so we may
> end up with the root window twice in the sprite trace.
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> Changes to v1:
> - keep DeepestSpriteWindow, but use firstChild to start looping

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140508/ecaff434/attachment.sig>

More information about the xorg-devel mailing list