[PATCH 2/3] sync: Serialise access to the fence before waking clients

Keith Packard keithp at keithp.com
Mon May 12 14:21:44 PDT 2014


Chris Wilson <chris at chris-wilson.co.uk> writes:

> diff --git a/miext/sync/misyncshm.c b/miext/sync/misyncshm.c
> index 01f82fc..4d11b57 100644
> --- a/miext/sync/misyncshm.c
> +++ b/miext/sync/misyncshm.c
> @@ -50,9 +50,9 @@ miSyncShmFenceSetTriggered(SyncFence * pFence)
>  {
>      SyncShmFencePrivatePtr      pPriv = SYNC_FENCE_PRIV(pFence);
>  
> +    miSyncFenceSetTriggered(pFence);
>      if (pPriv->fence)
>          xshmfence_trigger(pPriv->fence);
> -    miSyncFenceSetTriggered(pFence);

This seems fine, but unnecessary -- miSyncFenceSetTriggered only sets
pFence->triggered to TRUE so that internal X server references to that
value are correct after this.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140512/94dae180/attachment.sig>


More information about the xorg-devel mailing list