[PATCH 05/13] glamor: Add glamor_program based 0-width dashed lines

Keith Packard keithp at keithp.com
Fri May 23 10:46:46 PDT 2014

Keith Packard <keithp at keithp.com> writes:

> This makes sure the pixelization for dashed lines matches non-dashed
> lines, while also speeding them up.

This patch adds glamor_destroy_gc and requires that it be called to
avoid leaking the dash pixmap.

Unfortunately, UXA doesn't use glamor_gc_funcs, preferring to have its
own GCFuncs structure. That, of course, doesn't (currently) call

Here's an ugly kludge which checks to see if the GC will be using
glamor_destroy_gc, by testing inside of glamor_validate_gc, stashing the
current GC funcs in a local static and replacing the DestroyGC entry
with glamor_destroy_gc. This is very much UXA-specific, and only
necessary until UXA calls glamor_destroy_gc instead of miDestroyGC.

Thoughts about how to simply force UXA to be built correctly are
welcome; that would presumably be a better plan than this ugly hack.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-glamor-Kludge-around-UXA-not-using-glamor_gc_destroy.patch
Type: text/x-diff
Size: 1765 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140523/3ddd40af/attachment.patch>
-------------- next part --------------

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140523/3ddd40af/attachment.sig>

More information about the xorg-devel mailing list