[PATCH] glamor: Don't leak a prepare_access_gc() in putimage fallbacs.

Eric Anholt eric at anholt.net
Fri May 30 12:08:36 PDT 2014

It turns out putimage doesn't use the GC tile or stipple anyway, so
there's no need to do this.

Signed-off-by: Eric Anholt <eric at anholt.net>

I didn't see a followup email from either of you, so how about this
patch for the fixes tree?

 glamor/glamor_image.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/glamor/glamor_image.c b/glamor/glamor_image.c
index 4791d08..b38b412 100644
--- a/glamor/glamor_image.c
+++ b/glamor/glamor_image.c
@@ -88,8 +88,7 @@ static void
 glamor_put_image_bail(DrawablePtr drawable, GCPtr gc, int depth, int x, int y,
                       int w, int h, int leftPad, int format, char *bits)
-    if (glamor_prepare_access(drawable, GLAMOR_ACCESS_RW) &&
-        glamor_prepare_access_gc(gc))
+    if (glamor_prepare_access(drawable, GLAMOR_ACCESS_RW))
         fbPutImage(drawable, gc, depth, x, y, w, h, leftPad, format, bits);

More information about the xorg-devel mailing list