[PATCH 3/3] glamor: Choose max fbo size by texture + viewport size

Eric Anholt eric at anholt.net
Fri May 30 20:05:16 PDT 2014

Keith Packard <keithp at keithp.com> writes:

> Markus Wick <markus at selfnet.de> writes:
>> The max size of renderbuffers and texture often match by accident, but as we always use textures, we should check for the right flag.
>> Also check for viewport size as this may be lower and we want to
>> render to almost every pixmap.
> Using the max texture size seems completely sensible. However, I'm not
> sure we need to check the view port size as that is guaranteed to be
> larger than the display or the largest renderbuffer image which can be
> attached to a frame buffer. I realize it says only 'renderbuffer' here,
> and not something that encompasses both renderbuffers and textures, and
> so I think we need a gl spec interpreter to help disambiguate. In any
> case, it would be "insane" for viewports to be smaller than the largest
> texture which can be drawn to...

I think we would need to check either max texture and renderbuffer, or
texture and viewport.  I can definitely imagine implementations where
renderbuffer < texture, but it's hard to imagine an implementation where
renderbuffer != viewport.

I've put my r-b on this patch (and the previous one).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140530/2937a7b2/attachment.sig>

More information about the xorg-devel mailing list