[PATCH] os: "Server terminated successfully" is not an error

[Aaron Plattner]

ErrorFSigSafe calls LogVMessageVerbSigSafe with the message type set to X_ERROR.
That generates this in the log:

  (EE) Server terminated successfully (0). Closing log file.

People periodically report this as an error, sometimes quoting this "error"
rather than an earlier error that actually caused a problem.

Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
---
Is X_NOTICE too weird to use?  X_INFO would work too.

For reference, X_NOTICE is (!!) and X_INFO is (II).

 os/log.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/os/log.c b/os/log.c
index 7348ad4a2ea1..4716abb78a6f 100644
--- a/os/log.c
+++ b/os/log.c
@@ -257,8 +257,11 @@ void
 LogClose(enum ExitCode error)
 {
     if (logFile) {
-        ErrorFSigSafe("Server terminated %s (%d). Closing log file.\n",
-               (error == EXIT_NO_ERROR) ? "successfully" : "with error", error);
+        int msgtype = (error == EXIT_NO_ERROR) ? X_NOTICE : X_ERROR;
+        LogMessageVerbSigSafe(msgtype, -1,
+                "Server terminated %s (%d). Closing log file.\n",
+                (error == EXIT_NO_ERROR) ? "successfully" : "with error",
+                error);
         fclose(logFile);
         logFile = NULL;
         logFileFd = -1;
-- 
2.1.3