[PATCH 2/4] xfree86: Remove implicit xf86EnableIO from BSD for PowerPC

Mark Kettenis mark.kettenis at xs4all.nl
Wed Oct 15 13:07:55 PDT 2014


> From: Adam Jackson <ajax at redhat.com>
> Date: Wed,  8 Oct 2014 17:38:57 +0200
> 
> This shouldn't be necessary, we're doing this already at the DDX level
> when it's needed (and, more importantly, not when it's not).
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>

Tested (in 1.16.1) on a PowerMac G4 with an r128 on OpenBSD.  Although I
think that on OpenBSD we actually avoid accessing VGA registers.

Reviewed-by: Mark Kettenis <kettenis at openbsd.org>

> ---
>  hw/xfree86/os-support/bsd/ppc_video.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/xfree86/os-support/bsd/ppc_video.c b/hw/xfree86/os-support/bsd/ppc_video.c
> index b1cf7eb..f017376 100644
> --- a/hw/xfree86/os-support/bsd/ppc_video.c
> +++ b/hw/xfree86/os-support/bsd/ppc_video.c
> @@ -51,7 +51,6 @@ void
>  xf86OSInitVidMem(VidMemInfoPtr pVidMem)
>  {
>      pVidMem->initialised = TRUE;
> -    xf86EnableIO();
>  }
>  
>  volatile unsigned char *ioBase = MAP_FAILED;
> -- 
> 1.9.3


More information about the xorg-devel mailing list