[PATCH] composite: Wrap GetSpans

Keith Packard keithp at keithp.com
Wed Oct 22 13:37:08 PDT 2014


Adam Jackson <ajax at redhat.com> writes:

> GetSpans should flush composition from children to parent, just like
> GetImage and SourceValidate.  Fortunately no one is likely to have
> noticed, since to hit this you're already deep into failure town.

In the core server code, GetSpans is only used for miCopyArea,
miCopyPlane, miGetImage and miPushPixels. miPushPixels isn't relevant as
it is only ever used to read from pixmaps. The others are already
covered by the existing SourceValidate and GetImage wrappers.

Per our IRC discussion, fixing automatic compositing to correctly capture
IncludeInferiors rendering would require that we draw to the per-window
pixmaps for any inferior redirected window.

Nacked-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20141022/1e055410/attachment.sig>


More information about the xorg-devel mailing list