[PATCH xinit 0/1] startx: Pass "-nolisten tcp" by default

Hans de Goede hdegoede at redhat.com
Fri Sep 12 03:17:24 PDT 2014


Hi,

On 09/12/2014 11:12 AM, Mark Kettenis wrote:
>> From: Hans de Goede <hdegoede at redhat.com>
>> Date: Fri, 12 Sep 2014 09:25:17 +0200
>>
>> Hi All,
>>
>> After doing the 1.3.4 release yesterday, I've started working on updating the
>> Fedora packages to 1.3.4. While looking at our open bug list against xinit,
>> I found one bug which is not yet resolved in 1.3.4 .
>>
>> This patch fixes this, I realize that this is a behavior change, and as such
>> may be a bit controversial, but I really believe that in this day and age
>> "-nolisten tcp" by default is the right thing to do.
> 
> You're probably right.  However instead of fixing this in each and
> every bit of code that starts and X server, wouldn't it make more
> sense to simply change the default in the X server itself and add the
> -listen option there to override things?

I was thinking the same thing while working on this patch, the problem
is that most bits of code starting the xserver have already been patched
to start it with "-nolisten tcp", and have their own config file options /
cmdline options to override this.

Changing the server would break all this, where as just changing startx
keeps all of the existing other xserver "starters" working.

Regards,

Hans


More information about the xorg-devel mailing list