[PATCH xfree86 v2] systemd-logind.c: don't parse VT settings for non-seat0 X servers

Hans de Goede hdegoede at redhat.com
Fri Dec 4 01:15:18 PST 2015


Hi,

On 03-12-15 11:05, Laércio de Sousa wrote:
> Since non-seat0 X servers no longer touch VTs,
> I believe these settings are unnecessary.
>
> Signed-off-by: Laércio de Sousa <laerciosousa at sme-mogidascruzes.sp.gov.br>

Thanks, you're right keeptty is not used when !ServerIsNotSeat0():

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Ajax, can you pick this new version up please? This time I've compile
tested it on top of master.

Thanks & Regards,

Hans



> ---
>   hw/xfree86/os-support/linux/systemd-logind.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/xfree86/os-support/linux/systemd-logind.c b/hw/xfree86/os-support/linux/systemd-logind.c
> index 2612d9e..13784d1 100644
> --- a/hw/xfree86/os-support/linux/systemd-logind.c
> +++ b/hw/xfree86/os-support/linux/systemd-logind.c
> @@ -38,6 +38,7 @@
>   #include "xf86.h"
>   #include "xf86platformBus.h"
>   #include "xf86Xinput.h"
> +#include "globals.h"
>
>   #include "systemd-logind.h"
>
> @@ -615,7 +616,7 @@ static struct dbus_core_hook core_hook = {
>   int
>   systemd_logind_init(void)
>   {
> -    if (linux_parse_vt_settings(TRUE) && !linux_get_keeptty()) {
> +    if (!ServerIsNotSeat0() && linux_parse_vt_settings(TRUE) && !linux_get_keeptty()) {
>           LogMessage(X_INFO,
>               "systemd-logind: logind integration requires -keeptty and "
>               "-keeptty was not provided, disabling logind integration\n");
>


More information about the xorg-devel mailing list