[PATCH xserver 0/6] Use a thread for input

Keith Packard keithp at keithp.com
Wed Dec 9 11:42:34 PST 2015


Mark Kettenis <mark.kettenis at xs4all.nl> writes:

> Most of my objections to this Tiago's patch still apply.  Threads
> severely impact debuggability and this needs a full audit of all the
> drivers; not just the server.

I added the change which makes -dumbSched disable input threading to
ease debugging, although I haven't had any issues debugging
multithreaded code in a long time.

As for the driver audit, the only ones which need review are the few
active input drivers which weren't allowing SIGIO-based event processing
(libinput and keyboard). Not much to audit in either of those,
fortunately. Given that evdev already allowed SIGIO handling for all
devices, I think we've got good coverage for the X server itself.

Output drivers haven't always had to support sprite position changes at
SIGIO time, so they're all ready for this change.

The reason for this change is that libinput isn't willing to tolerate
reading events at SIGIO time as that means not being able to use most of
libc. In the process of doing this work, I uncovered numerous existing
places which were calling inappropriate libc functions from the SIGIO
context; this change will fix those as well as allowing us to eliminate
kludges working around this limitation.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151209/29b77aa1/attachment.sig>


More information about the xorg-devel mailing list