[PATCH inputproto] specs: Set TZ=UTC before calling asciidoc

[Andreas Boll]

2015-12-11 10:20 GMT+01:00 Uli Schlachter <psychon at znc.in>:
> Am 10.12.2015 um 21:25 schrieb Andreas Boll:
>> Set TZ=UTC before calling asciidoc to make the embedded dates invariant
>> to timezones in order to make the package build reproducibly.
>>
>> Fixes bug:
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795981
>>
>> Suggested-by: Eduard Sanou <dhole at openmailbox.org>
>> Signed-off-by: Andreas Boll <andreas.boll.dev at gmail.com>
>> ---
>>  specs/Makefile.am | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/specs/Makefile.am b/specs/Makefile.am
>> index a83cf40..d04f4d0 100644
>> --- a/specs/Makefile.am
>> +++ b/specs/Makefile.am
>> @@ -6,7 +6,7 @@ doc_DATA = XI2proto.html XIproto.html
>>  dist_doc_DATA = XI2proto.txt XIproto.txt
>>
>>  %.html: %.txt
>> -     $(AM_V_GEN)$(ASCIIDOC) -o $@ $<
>> +     TZ=UTC $(AM_V_GEN)$(ASCIIDOC) -o $@ $<
>
> Shouldn't this be $(AM_V_GEN)TZ=UTC $(ASCIIDOC) -o $@ $<?
>
> $(AM_V_GEN) can evaluate to '@echo "  GEN    " $@;' which would break the build
> (make wouldn't see the @-prefix and your env var is only passed to echo)
>
Indeed, fixed in v2
We tested this only on verbose builds.

Thanks for the review,
Andreas


>>
>>  CLEANFILES = $(doc_DATA)
>>
>>
>
> Uli
> --
> A normal person is just someone you don't know well enough yet.
>  - Nettie Wiebe