[PATCH xserver 4/9] Create a threaded mechanism for input [v3]

[Keith Packard]

Peter Hutterer <peter.hutterer at who-t.net> writes:

I've squashed the two patches which add threaded input together; those
were intended to be merged once Mark had finished reviewing the mutex
changes. I'll respond to the questions about the second patch separately.

> drop the s after select()

done.

> shouldn't this set InputThreadEnable as well? afaict right now it's always
> enabled, regardless what we say here (except that it'll probably fail the
> build since the libs are missing).

Yes, that was the patch as I received it from Tiago. The subsequent
patch fixed that. I've merged those two together as Mark has reviewed
the mutex changes separately now.

> you're using quotes for the others but not here

Fixed.

> indentation

Tabs. Yikes! That looks like it's the only one

> I'd rename that to 'node' rather than list, to make it more obvious that
> this is not a list head.

Done.

> drop the  {}

Done.

> urgh, can we use "dev" or "new_device" here, rather than just "new"?

Yup. Using 'dev'.

> missing a closing )

Fixed.

> use a boolean "found_device" or so here, much nicer to grasp than the list
> pointer comparison.

Done.

> __func__ for all three?

I don't understand; do you want __func__ to be displayed in these error
and debug printfs?

> please wrap the xorg_list loop in { }

Done.

Here's a new patch which merges 4/9 and 5/9 into 4/8

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Create-a-threaded-mechanism-for-input-v4.patch
Type: text/x-diff
Size: 23803 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151217/b4dd3409/attachment-0001.patch>
-------------- next part --------------


-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151217/b4dd3409/attachment-0001.sig>