[PATCH xserver 2/9] Remove SIGIO support for input [v2]

[Keith Packard]

Peter Hutterer <peter.hutterer at who-t.net> writes:

> don't know what the point of saving errno is here, but this should be a
> separate patch, you're changing functionality here.

It's saving errno during a signal handler; now that we have no signal
handler, we don't need to save errno anymore. Not that I think we
actually needed to save errno here; it looks like cult code to me. I'll
split it out into a separate patch.

> the FALSE needs a comment, otherwise it's confusing.

Ok, I'll add the comment in this patch and remove it in the next.

> shouldn't this be in the previous patch?

I think those two patches should probably be merged together; the stubs
aren't used until this patch. Let me do that.

Here's an amended version of this patch which has been squashed with the
first patch that added the stubs, and has had the errno wrapping left
in in xf86Events., along with newly worded comments in xf86Helper.c.

I've added a patch to the series which separately removes the errno
wrapping bits in xf86Events.c, and then changed the input thread adding code to reword
the comment in xf86Helper.c. The overall change at the end is just a
better wording of the comment in xf86Helper.c. I've pushed out a new
version of my input-thread branch to my tree if you want to see the
whole series.

diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
index 0aeefd6..4a17430 100644
--- a/hw/xfree86/common/xf86Helper.c
+++ b/hw/xfree86/common/xf86Helper.c
@@ -1725,9 +1725,7 @@ xf86SetSilkenMouse(ScreenPtr pScreen)
     }
     free(options);
     /*
-     * XXX quick hack to report correctly for OSs that can't do SilkenMouse
-     * yet.  Should handle this differently so that alternate async methods
-     * work correctly with this too.
+     * Use silken mouse if requested and if we have threaded input
      */
     pScrn->silkenMouse = useSM && InputThreadEnable;
     if (serverGeneration == 1)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-SIGIO-support-for-input-v3.patch
Type: text/x-diff
Size: 39758 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151217/383ffd8d/attachment-0001.patch>
-------------- next part --------------

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151217/383ffd8d/attachment-0001.sig>