[PATCH 0/5] Switching from HW cursor to SW cursor

[Keith Packard]

Michel Dänzer <michel at daenzer.net> writes:

> This series addresses two cases in which a HW cursor cannot be used:
>
> 1) When a transform is active on a CRTC. Patch 2 adds a CRTC hook
>    use_hw_cursor_argb, which allows drivers to force SW cursor on a
>    per-CRTC basis. However, this hook alone could only force SW cursor
>    as of the next time a new cursor image is set. The
>    xf86CursorResetCursor function added in patch 1 allows switching
>    between HW cursor and SW cursor immediately.

Hrm. This code is really hard to review because there are now two pairs
of functions checking whether software or hardware cursors should be
used -- the per-screen UseHWCursor/UseHWCursorARGB and the per-crtc ones
you're adding here. As a suggestion, would it be reasonable to use the
existing UseHWCursor/UseHWCursorARGB as proxies for the per-crtc
functions when the per-crtc ones don't exist? Would that let use remove
all of the SW cursor checking code from xf86Cursor.c, and simply use the
code from xf86Cursors.c?

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151222/542ff48d/attachment.sig>