[PATCH:xf86-video-mga] Fix pointer cast warning.
lists.tormod at gmail.com
Wed Feb 25 02:31:50 PST 2015
On Tue, Feb 24, 2015 at 7:36 AM, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
>> cast to pointer from integer of different size
>> Signed-off-by: Thomas Klausner <wiz at NetBSD.org>
>> src/mga_exa.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> This code makes no sense to me. exaGetPixmapFirstPixel() returns a pixel
> value. Interpreting that as a pointer to the first pixel must be wrong.
Are you sure about this? What would be the utility of a function
returning the pixel /value/ of the first pixel in a pixmap?
> Note that the actual usage of mgaDownloadFromScreen() is #if 0'ed out.
> Perhaps this code should just be removed from the driver? Or perhaps the
> code was #if 0'ed out because the code didn't work?
About the EXA code working or not, see also
More information about the xorg-devel