[PATCH] modesetting: Copy over VRefresh to/from KMS modes

[Jasper St. Pierre]

I mean, if you're going to break the ABI for this, can we fix it so that we
have one mode structure instead of three?

On Thu, Jan 8, 2015 at 4:56 PM, Keith Packard <keithp at keithp.com> wrote:

> "Jasper St. Pierre" <jstpierre at mecheye.net> writes:
>
> > Fine by me. I actually stopped using vrefresh in my kernel driver and
> > instead started using drm_mode_vrefresh, so we can actually drop this
> > patch.
>
> Oh, we should send the correct vrefresh value to the kernel; it's part
> of the API after all. Having an integer vrefresh value isn't all that
> useful anyways; we often end up with multiple
> similar-but-not-quite-the-same modes that differ by less than 1Hz in
> vrefresh.
>
> But, removing VRefresh from the X server and then sending a
> computed value to the kernel seems like a fine plan.
>
> For now, we need to retain ABI in X, so using your existing plan which
> computes the value to send to the kernel seems appropriate. That just
> needs to be fixed to round the value rather than truncate and I think
> we'll be set for 1.17 at least.
>
> --
> -keith
>



-- 
  Jasper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150108/2e051355/attachment-0001.html>