[PATCH synaptics] Remove FastTap leftovers

Peter Hutterer peter.hutterer at who-t.net
Sun Jan 11 17:12:23 PST 2015


On Fri, Jan 09, 2015 at 05:01:42PM +0100, Gabriele Mazzotta wrote:
> FastTap was removed with d14ea867ad5d ("Purge fast-taps option"),
> remove all of what remained.
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt at gmail.com>
> ---
>  include/synaptics-properties.h | 3 ---
>  man/synaptics.man              | 3 ---
>  tools/synclient.c              | 1 -
>  3 files changed, 7 deletions(-)
> 
> diff --git a/include/synaptics-properties.h b/include/synaptics-properties.h
> index 08a0a3d..f73a84a 100644
> --- a/include/synaptics-properties.h
> +++ b/include/synaptics-properties.h
> @@ -51,9 +51,6 @@
>  /* 8 bit (BOOL) */
>  #define SYNAPTICS_PROP_CLICKPAD "Synaptics ClickPad"
>  
> -/* 8 bit (BOOL) */
> -#define SYNAPTICS_PROP_TAP_FAST "Synaptics Tap FastTap"
> -

I've left this #define in to avoid breaking anything using it. Clients need
to check whether a property actually exists anyway, removing the define may
stop them from compiling. I added a 'deprecated' to the comment and pushed
it, thanks.

Cheers,
   Peter

>  /* 32 bit */
>  #define SYNAPTICS_PROP_MIDDLE_TIMEOUT "Synaptics Middle Button Timeout"
>  
> diff --git a/man/synaptics.man b/man/synaptics.man
> index ee5ad3d..c28cc22 100644
> --- a/man/synaptics.man
> +++ b/man/synaptics.man
> @@ -619,7 +619,6 @@ A too long value can cause undesirable autorepeat in scroll bars and a
>  too small value means that visual feedback from the gui application
>  you are interacting with is harder to see.
>  .
> -For this parameter to have any effect, "FastTaps" has to be disabled.
>  .SS Acceleration
>  The MinSpeed, MaxSpeed and AccelFactor parameters control the pointer
>  motion speed.
> @@ -995,8 +994,6 @@ The following options are no longer part of the driver configuration:
>  .TP
>  .BI "Option \*qTrackstickSpeed\*q \*q" float \*q
>  .TP
> -.BI "Option \*qFastTaps\*q \*q" boolean \*q
> -.TP
>  .BI "Option \*qEdgeMotionMinZ\*q \*q" integer \*q
>  .TP
>  .BI "Option \*qEdgeMotionMaxZ\*q \*q" integer \*q
> diff --git a/tools/synclient.c b/tools/synclient.c
> index ef61259..f128b44 100644
> --- a/tools/synclient.c
> +++ b/tools/synclient.c
> @@ -86,7 +86,6 @@ static struct Parameter params[] = {
>      {"MaxDoubleTapTime",      PT_INT,    0, 1000,  SYNAPTICS_PROP_TAP_DURATIONS,32,	1},
>      {"SingleTapTimeout",      PT_INT,    0, 1000,  SYNAPTICS_PROP_TAP_DURATIONS,32,	0},
>      {"ClickTime",             PT_INT,    0, 1000,  SYNAPTICS_PROP_TAP_DURATIONS,32,	2},
> -    {"FastTaps",              PT_BOOL,   0, 1,     SYNAPTICS_PROP_TAP_FAST,	8,	0},
>      {"EmulateMidButtonTime",  PT_INT,    0, 1000,  SYNAPTICS_PROP_MIDDLE_TIMEOUT,32,	0},
>      {"EmulateTwoFingerMinZ",  PT_INT,    0, 1000,  SYNAPTICS_PROP_TWOFINGER_PRESSURE,	32,	0},
>      {"EmulateTwoFingerMinW",  PT_INT,    0, 15,    SYNAPTICS_PROP_TWOFINGER_WIDTH,	32,	0},
> -- 
> 2.1.4
> 


More information about the xorg-devel mailing list