[PATCH] Fix a crash with XDMCP error handler

Olivier Fourdan ofourdan at redhat.com
Thu Jan 22 00:48:35 PST 2015


Hi

On 21/01/15 19:32, patrick keshishian wrote:
> Excuse my naive observation; I'm possibly missing something.
> The comment states "status length is CARD8" but the header
> file (If I'm looking at the correct one) states it is CARD16:
>
> http://cgit.freedesktop.org/xorg/lib/libXdmcp/tree/include/X11/Xdmcp.h#n80
>
> Possibly a mistake/oversight in type definition as ARRAY{16,32}
> do have lengths of type CARD8.

Yes, you're right, I got confused by:

http://cgit.freedesktop.org/xorg/xserver/tree/os/xdmcp.c#n743

Will send an updated patch in a minute.

Cheers,
Olivier



More information about the xorg-devel mailing list