[PATCH] Drop valuator mask argument from GetKeyboardEvents

Daniel Stone daniel at fooishbar.org
Wed Jan 28 09:53:27 PST 2015


Hi,

On 17 December 2014 at 02:33, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> On Tue, Dec 16, 2014 at 08:15:31AM +0000, Daniel Stone wrote:
>> Are you sure this is right? Won't this change it from returning root_[xy]
>> with current MD pointer co-ordinates to nothing/rubbish?
>
> no, this actually works, albeit mostly because of the usual mess.
>
> ProcesDeviceEvent() updates the sprite for motion events (CheckMotion), and
> then fills that position in for KeyPress events. so yes, the root coords are
> garbage but since we only use those for motion events it doesn't matter.

Ah yes, I'd forgotten about that; guess time really does heal all wounds.

Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the xorg-devel mailing list