[PATCH] glamor_egl: Properly free resources on init-error and exit

Keith Packard keithp at keithp.com
Wed Jul 8 11:10:50 PDT 2015


Eric Anholt <eric at anholt.net> writes:

> Hans de Goede <hdegoede at redhat.com> writes:
>
>> glamor_egl_init() was not undoing any of the init steps on init error,
>> add an glamor_egl_cleanup() function and use this both on error and on exit
>> to cleanup the various resources.
>>
>> Even on a clean exit eglTerminate() was not being called, causing the fd
>> dup()-ed by eglInitialize() to stay open, call eglTerminate() from the new
>> glamor_egl_cleanup() to fix this.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>
> Reviewed-by: Eric Anholt <eric at anholt.net>
>
> I'll stick it in my next pull request, unless keithp grabs it first.

Nope, happy to wait for you. I shouldn't be pulling glamor stuff
directly ever.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150708/484cc88e/attachment.sig>


More information about the xorg-devel mailing list