glamor: rendercheck fixes and picture handling simplification

Michel Dänzer michel at daenzer.net
Wed Jul 8 21:03:56 PDT 2015


On 09.07.2015 04:45, Eric Anholt wrote:
> This series came out of the process of trying to figure out if I could
> safely store a8 pixmaps in an a8r8g8b8 FBO, to improve glamor
> performance on VC4 (which doesn't support 8-bit FBOs).  It turns out
> the answer is "not quite", but the Render code had a lot of bugs
> obscuring that fact.

Patches 1, 3-5, 8, 10-12 are

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


Patch 2: Should the shortlog say "choosing format" instead of "choosing
color"? Either way,

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


Patch 9: Maybe add an XXX comment that we're overshooting for
transforms? Either way,

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


I don't really understand the code changed by patch 6 & 7, but they're

Acked-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-devel mailing list