[PATCH] modesetting: Use correct datatypes for return values from glamor_name_from_pixmap and glamor_fd_from_pixmap

Eric Anholt eric at anholt.net
Thu Jul 16 12:31:52 PDT 2015


Robert Ancell <robert.ancell at canonical.com> writes:

> glamor_name_from_pixmap and glamor_fd_from_pixmap return CARD16 and CARD32 values via pointers.
> The current code uses uint16_t and uint32_t which will probably be the same but it's safer to use
> the datatypes as specified by the function.
>
> Signed-off-by: Robert Ancell <robert.ancell at canonical.com>

This fixes warnings on my armhf builds.  Thanks!  My only change would
be to line-wrap the commit message and make the subject line fit:

commit 29efa905ec1e22d66b517378c6e5ad47a09d6977
Author: Robert Ancell <robert.ancell at canonical.com>
Date:   Thu Jul 16 12:26:05 2015 +1200

    modesetting: Use correct types for return values of glamor BO exports.
    
    glamor_name_from_pixmap and glamor_fd_from_pixmap return CARD16 and
    CARD32 values via pointers.  The current code uses uint16_t and
    uint32_t which will probably be the same but it's safer to use the
    datatypes as specified by the function.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150716/6bdd2bd7/attachment.sig>


More information about the xorg-devel mailing list