[PATCH v3 0/4] xprop: Free various allocated memory

Eirik Byrkjeflot Anonsen eirik at eirikba.org
Mon Jun 1 02:31:10 PDT 2015


Eirik Byrkjeflot Anonsen <eirik at eirikba.org> writes:

> Some time late in 2014 I noticed that one of the processes using the most
> memory on my system was called "xprop". I found this a bit surprising, so
> I investigated and found that this particular tool generally didn't free
> any of the memory it allocated. Which is usually not a problem, since it
> just runs and exits. However, the -spy option makes it run forever, and it
> seems something on my system is using that to monitor the properties on
> the root window.
>
> v2: Set 'prop' to NULL after XFree(prop).
> v3: Simplifications
>   - Inline and remove Free_Thunk_List()
>   - Let free() deal with NULL pointers
[...]

Looks like nobody has any further comments on this. I believe I have
addressed all concerns that were raised (either by fixing the code or by
saying why I think my solution is better).

So I guess all we need now is someone who is willing to review changes
to xprop. And then someone who is willing and able to push these patches
to the official version. Any takers?

eirik


More information about the xorg-devel mailing list