[PATCH] int10: Fix mapping the interrupt vector

Alex Deucher alexdeucher at gmail.com
Wed Mar 4 09:59:15 PST 2015


On Wed, Mar 4, 2015 at 12:51 PM, Adam Jackson <ajax at redhat.com> wrote:
> pci_device_map_legacy returns 0 on success, and an errno value on
> failure.  It works a lot better if we don't treat 0 as failure.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>

Good catch!

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  hw/xfree86/int10/generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xfree86/int10/generic.c b/hw/xfree86/int10/generic.c
> index 012d194..8d5c4da 100644
> --- a/hw/xfree86/int10/generic.c
> +++ b/hw/xfree86/int10/generic.c
> @@ -104,7 +104,7 @@ readIntVec(struct pci_device *dev, unsigned char *buf, int len)
>  {
>      void *map;
>
> -    if (!pci_device_map_legacy(dev, 0, len, 0, &map))
> +    if (pci_device_map_legacy(dev, 0, len, 0, &map))
>          return FALSE;
>
>      memcpy(buf, map, len);
> --
> 1.9.3
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


More information about the xorg-devel mailing list