[PATCH:libx11] parse_omit_name should increase num of fields before appending encoding

Alan Coopersmith alan.coopersmith at oracle.com
Mon Mar 16 17:16:27 PDT 2015


On 03/15/15 11:39 PM, Hong Xu wrote:
> parse_omit_name currently does not increase number of fields to 12 after
> appending encoding, This does not lead to the correct font is a xlfd
> like "-*-*-medium-r-*-*-33-*" is given.
>
> Signed-off-by: Hong Xu <hong at topbug.net>
>
> ---
> Please note that the "if" in this patch is replaced by "while". The
> reason is that I found the commit 3d69b0a83e62f8f6fbd changed the
> "while" to "if", which does not seems logically correct for me and
> actually accidently "fixed" the bug
> http://sourceware.org/bugzilla/show_bug.cgi?id=10948

Multiple people found and fixed that bug - I am not going to revert
the change and destroy performance without a better reason than one
person not understanding the fix.

It's not just the bug you cite, but was also a bug our Solaris i18n team
found and fixed:
    https://hg.java.net/hg/solaris-x11~x-s12-clone/rev/6fe48a3a12bf
and one Thomas Dickey found and fixed while investigating xterm performance:
    http://invisible-island.net/xterm/xterm.faq.html#slow_menus

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list