[PATCH 1/2] xserver: add xorg.conf support for gpu devices.

[Emil Velikov]

Hi Dave,

On 31/03/15 07:12, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> This allows gpu devices to be specified in xorg.conf Screen sections.
> 
> Section "Device"
>         Driver "intel"
>         Identifier "intel0"
>         Option "AccelMethod" "uxa"
> EndSection
> 
> Section "Device"
>         Driver "modesetting"
>         Identifier "usb0"
> EndSection
> 
> Section "Screen"
>         Identifier "screen"
>         Device "intel0"
>         GPUDevice "usb0"
> EndSection
> 
> This should allow for easier tweaking of driver options which
> currently mess up the GPU device discovery process.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  hw/xfree86/common/xf86Config.c | 39 +++++++++++++++++++++++++++++----------
>  hw/xfree86/common/xf86Helper.c | 13 ++++++++++++-
>  hw/xfree86/common/xf86str.h    |  3 +++
>  hw/xfree86/man/xorg.conf.man   | 13 +++++++++++++
>  hw/xfree86/parser/Screen.c     | 20 ++++++++++++++++++--
>  hw/xfree86/parser/xf86Parser.h |  5 +++++
>  hw/xfree86/parser/xf86tokens.h |  1 +
>  7 files changed, 81 insertions(+), 13 deletions(-)
[...]
> diff --git a/hw/xfree86/common/xf86str.h b/hw/xfree86/common/xf86str.h
> index 643a65d..9893f98 100644
> --- a/hw/xfree86/common/xf86str.h
> +++ b/hw/xfree86/common/xf86str.h
> @@ -453,6 +453,9 @@ typedef struct _confscreenrec {
>      int numxvadaptors;
>      confXvAdaptorPtr xvadaptors;
>      void *options;
> +
> +    int num_gpu_devices;
> +    GDevPtr gpu_devices[4];
What would happen if one provides more than 4 GPUDevices ? Is there a
check which I'm missing or are we overwriting memory ? On a related note
- using the CONFMAXGPUDEVICES macro would be great :-)


Cheers,
Emil