[PATCH 1/7] render: Inline common FindGlyph case

Eric Anholt eric at anholt.net
Thu May 14 15:51:53 PDT 2015


Keith Packard <keithp at keithp.com> writes:

> Provide the common path for FindGlyph as an inline function, falling
> back to a function for the slow case.

From the end of your current branch, reverting this commit gives me this
on aa10text:

x glamor-new-glyphs
+ revert
+-------------------------------------------------------------------------------+
|                                    xx    +                                    |
|                                    xx +  +                                    |
|                                    xx +  +                                    |
|                                   xxx *  +                                    |
|                                   xxx *+++  +                                 |
|                                xx xx* *++++++x                                |
|                                xxxxx*+**+++++x                                |
|                                xxxxx****+++++x                                |
|                           x    xxxxx****+++++x x  ++ ++                       |
|                           x  x xxxxx****+++++x x  ++ ++ +                     |
|                           x  xxx*x*******++++x**+ ++ ++ +                     |
|                           x xxxx*x*********+****+ ++ ++++ +                   |
|                   x  xx   x xxxx*x*********+***** ++ ++++ +                   |
|                x  x  xx   x xxxx******************+*+++++ ++                  |
|x               x  xx xx   *x***************************+*++++                x|
|                             |_______|_____MA_|_____|                          |
+-------------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x 193       5810000       8400000       7030000     7043937.8     284806.29
+ 192       6690000       7850000       7250000     7284270.8     246558.49
Difference at 95.0% confidence
	240333 +/- 53225.9
	3.41191% +/- 0.755628%
	(Student's t, pooled s = 266420)

So I don't think we should land this.  The prep patch of clearing
signature would still be fine with me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150514/9369e7f8/attachment.sig>


More information about the xorg-devel mailing list