[PATCH v2 2/2] systemd-logind: Only use systemd-logind integration together with keeptty

[Aaron Plattner]

On 05/16/2015 01:03 AM, Hans de Goede wrote:
> Hi,
>
> On 15-05-15 22:21, Aaron Plattner wrote:
>> On 04/30/2015 05:24 AM, Hans de Goede wrote:
>>> systemd-logind integration does not work when starting X on a new
>>> tty, as
>>> that detaches X from the current session and after hat systemd-logind
>>> revokes
>>> all rights any already open fds and refuses to open new fds for X.
>>>
>>> This means that currently e.g. "startx -- vt7" breaks, and breaks badly,
>>> requiring ssh access to the system to kill X.
>>>
>>> The fix for this is easy, we must not use systemd-logind integration
>>> when
>>> not using KeepTty, or iow we may only use systemd-logind integration
>>> together
>>> with KeepTty.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>>
>> I can confirm that this fixes VT switching for X servers started from
>> an SSH session on Arch Linux, which I use all the time for debugging. So
>>
>> Tested-by: Aaron Plattner <aplattner at nvidia.com>
>
> Thanks, note that testing in Fedora has found a minor issue when running
> headless (with the dummy driver),
> so a v3 of the patch-set is coming up, see:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1203780#c8
>
> I'm waiting from feedback from the reporter before posting v3.
>
> In the mean time you can grab v3 of the patch-set here:
>
> http://cgit.freedesktop.org/~jwrdegoede/xserver/
>
> (it is now 3 patches).

Thanks! I can confirm that merging commit 
d7855745890d42ed56ceb97857081e9097acec12 also fixes the problem for me, 
so you can feel free to add my Tested-by line to those as well.

-- 
Aaron