[PATCH v2 1/4] Free the thunks used by Show_Prop

[Eirik Byrkjeflot Anonsen]

walter harms <wharms at bfs.de> writes:

> Am 21.05.2015 14:55, schrieb Eirik Byrkjeflot Anonsen:
>> Signed-off-by: Eirik Byrkjeflot Anonsen <eirik at eirikba.org>
>> ---
>>  xprop.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>> 
>> diff --git a/xprop.c b/xprop.c
>> index 4c4c702..ba23b87 100644
>> --- a/xprop.c
>> +++ b/xprop.c
>> @@ -95,13 +95,11 @@ Create_Thunk_List (void)
>>      return tptr;
>>  }
>>  
>> -#ifdef notused
>>  static void
>>  Free_Thunk_List (thunk *list)
>>  {
>>      free(list);
>>  }
>> -#endif
>>  
>>  static thunk *
>>  Add_Thunk (thunk *list, thunk t)
>> @@ -1519,8 +1517,8 @@ Show_Prop (const char *format, const char *dformat, const char *prop)
>>      }
>>  
>>      thunks = Break_Down_Property(data, (int)length, type, format, size);
>> -
>>      Display_Property(thunks, dformat, format);
>> +    Free_Thunk_List(thunks);
>>  }
>>  
>>  static void
>
> why not simply free(thunks) ?

Hmm, mostly because the Free_Thunk_List() function already existed, I
think. It seemed natural to use it. Either way works for me, though.

eirik