[PATCH 2/5] glamor: New render code can't handle non-repeating sources

Keith Packard keithp at keithp.com
Tue May 26 13:47:52 PDT 2015


GL doesn't have a texture wrap mode that matches Renders non-repeating
sources, so for now, we'll just bail on this case.

Signed-off-by: Keith Packard <keithp at keithp.com>
---
 glamor/glamor_program.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/glamor/glamor_program.c b/glamor/glamor_program.c
index 1dc5f19..8145cc1 100644
--- a/glamor/glamor_program.c
+++ b/glamor/glamor_program.c
@@ -604,11 +604,11 @@ glamor_setup_program_render(CARD8                 op,
 
     if (src->pDrawable) {
 
-        /* Can't do transforms, alphamaps or sourcing from non-pixmaps yet */
-        if (src->transform || src->alphaMap || src->pDrawable->type != DRAWABLE_PIXMAP)
+        /* Can't do transforms, alphamaps, non-repeat or sourcing from non-pixmaps yet */
+        if (src->transform || src->alphaMap || !src->repeat || src->pDrawable->type != DRAWABLE_PIXMAP)
             return NULL;
 
-        if (src->pDrawable->width == 1 && src->pDrawable->height == 1 && src->repeat)
+        if (src->pDrawable->width == 1 && src->pDrawable->height == 1)
             source_type = glamor_program_source_1x1_picture;
         else
             source_type = glamor_program_source_picture;
-- 
2.1.4



More information about the xorg-devel mailing list