[PATCH] present: Execute right away if target_msc equals current_msc

Axel Davy axel.davy at ens.fr
Tue Nov 3 00:50:46 PST 2015


Sorry, I haven't push access either,

but you shouldn't worry about getting your patch in,
usually before releases all reviewed pending patches on the ml are pushed.

Else perhaps someone from the amd open source team has push access and could
push your patch.

Yours,

Axel

On 03/11/2015 09:32, Zhou, Jammy wrote:
>> It should arrive soon, it awaits moderation approval.
> Sounds good. So could you help get my patch pushed together with your upcoming patch? I don't think I have permission for the push now. Thanks!
>
> Regards,
> Jammy
>
> -----Original Message-----
> From: Axel Davy [mailto:axel.davy at ens.fr]
> Sent: Tuesday, November 03, 2015 4:19 PM
> To: Zhou, Jammy; xorg-devel at lists.x.org
> Subject: Re: [PATCH] present: Execute right away if target_msc equals current_msc
>
> Reviewed-by: Axel Davy <axel.davy at ens.fr>
>
> BTW, I've just sent a patch to fix the PresentOptionAsync behaviour (we want to use sync flips when target_msc is above crtc_msc).
> It should arrive soon, it awaits moderation approval.
>
> On 28/10/2015 11:39, Jammy Zhou wrote:
>> It is according to the protocol:
>>
>> "If 'options' contains PresentOptionAsync, and the 'target-msc'
>> is less than or equal to the current msc for 'window', then the
>> operation will be performed as soon as possible, not necessarily
>> waiting for the next vertical blank interval."
>>
>> Signed-off-by: Jammy Zhou <Jammy.Zhou at amd.com>
>> ---
>>    present/present.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/present/present.c b/present/present.c index
>> beb4ff0..5900c22 100644
>> --- a/present/present.c
>> +++ b/present/present.c
>> @@ -871,7 +871,7 @@ present_pixmap(WindowPtr window,
>>    
>>        xorg_list_add(&vblank->event_queue, &present_exec_queue);
>>        vblank->queued = TRUE;
>> -    if ((pixmap && target_msc >= crtc_msc) || (!pixmap && target_msc > crtc_msc)) {
>> +    if (target_msc > crtc_msc) {
>>            ret = present_queue_vblank(screen, target_crtc, vblank->event_id, target_msc);
>>            if (ret == Success)
>>                return Success;



More information about the xorg-devel mailing list